Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automatic install to target new Apple silicon release binaries #505

Closed
Swiftwork opened this issue Mar 29, 2023 · 2 comments
Closed
Labels
help wanted Extra attention is needed

Comments

@Swiftwork
Copy link

With version, 21+ protobuf releases precompiled binaries for Apple silicon https://github.com/protocolbuffers/protobuf/releases/tag/v21.0-rc1.

Currently, version 2.8.3 of protoc ignores the arch flag for darwin in the makeReleaseName function:

https://github.com/timostamm/protobuf-ts/blob/v2.8.3/packages/protoc/util.js#L174-L196

It would be great to have this updated.

@timostamm
Copy link
Owner

I agree.

A small complication: The package allows to install a specific version, and older releases of protoc aren't backfilled. So enabling the arm architecture is a breaking change. So the code path should only use arm for protoc versions that >=21 via a denylist or parsing the version.

Happy to take a contribution!

@timostamm timostamm added the help wanted Extra attention is needed label Mar 29, 2023
@timostamm
Copy link
Owner

Hey @Swiftwork, with #517 released in v2.9.0, this should be fixed. Please re-open if I'm wrong 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants