Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks with 32-bit NodeJS #515

Closed
wildmichael opened this issue Apr 14, 2023 · 2 comments
Closed

Breaks with 32-bit NodeJS #515

wildmichael opened this issue Apr 14, 2023 · 2 comments

Comments

@wildmichael
Copy link

wildmichael commented Apr 14, 2023

E.g. the NodeJS v16.14.0 shipped with Visual Studio 2022 is 32 bit and returns for os.arch() the value "ia32". This breaks in makeReleaseName() of utils.js, where for the "win32" platform only the values "x32" and "x64" are checked. According to the NodeJS documentation, os.arch() never returns "x32", only "ia32".

This is trivially fixed by modifying the check:

        case "win32":
            if (params.arch === "x64") {
                build = 'win64'
            } else if (params.arch === "ia32") {
                build = 'win32'
            }
            break;
@wildmichael wildmichael changed the title Breaks with NodeJS shipped with Visual Studio 2022 Breaks with 32-bit NodeJS Apr 14, 2023
@timostamm
Copy link
Owner

This should be fixed by #517

@timostamm
Copy link
Owner

The fix was released in v2.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants