Bugfix #1375: --dont-order-by-type broken

PyCQA · Aug 12, 2020 · 680c92b · 680c92b
1 parent 65f9e94
commit 680c92b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/isort/main.py b/isort/main.py
@@ -745,6 +745,7 @@ def parse_args(argv: Optional[Sequence[str]] = None) -> Dict[str, Any]:
         arguments["remapped_deprecated_args"] = remapped_deprecated_args
     if "dont_order_by_type" in arguments:
         arguments["order_by_type"] = False
+        del arguments["dont_order_by_type"]
     multi_line_output = arguments.get("multi_line_output", None)
     if multi_line_output:
         if multi_line_output.isdigit():

diff --git a/tests/test_main.py b/tests/test_main.py
@@ -39,6 +39,8 @@ def test_parse_args():
     assert main.parse_args([]) == {}
     assert main.parse_args(["--multi-line", "1"]) == {"multi_line_output": WrapModes.VERTICAL}
     assert main.parse_args(["--multi-line", "GRID"]) == {"multi_line_output": WrapModes.GRID}
+    assert main.parse_args(["--dont-order-by-type"]) == {"order_by_type": False}
+    assert main.parse_args(["--dt"]) == {"order_by_type": False}
 
 
 def test_ascii_art(capsys):