Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UMD #24

Open
iofjuupasli opened this issue Apr 8, 2016 · 3 comments · May be fixed by #29
Open

UMD #24

iofjuupasli opened this issue Apr 8, 2016 · 3 comments · May be fixed by #29

Comments

@iofjuupasli
Copy link

https://github.com/umdjs/umd/blob/master/templates/commonjsStrict.js

Can you please add build compatible with globals and AMD?
@timoxley
Copy link
Owner

I don't use UMD but I'd accept a PR for this.

bigomega added a commit to bigomega/keycode that referenced this issue Aug 18, 2016
@bigomega
timoxley#24 making the library UMD - support for AMD and global
aca6b22
@bigomega bigomega linked a pull request Aug 18, 2016 that will close this issue
Open
@aaronbeall
Copy link
Contributor

Related to this I just submitted a PR to update the type defs to define UMD "properly" per TS 2.0 native UMD support: #37

Interestingly the existing type-defs already expose both a global and a module.

@mikemaccana
Copy link

Does anyone use AMD anymore? CommonJS is popular, .mjs / TC39 modules are coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UMD - Support for AMD and globals bigomega/keycode
4 participants
@timoxley @mikemaccana @iofjuupasli @aaronbeall