A tiny puppet change #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redace85
added a commit
to redace85/damn-vulnerable-defi
that referenced
this pull request
Jul 4, 2022
redace85
added a commit
to redace85/damn-vulnerable-defi
that referenced
this pull request
Jul 7, 2022
redace85
added a commit
to redace85/damn-vulnerable-defi
that referenced
this pull request
Jul 7, 2022
zzzuhaibmohd
added a commit
to zzzuhaibmohd/damn-vulnerable-defi-solutions
that referenced
this pull request
Jul 19, 2022
zzzuhaibmohd
added a commit
to zzzuhaibmohd/damn-vulnerable-defi-solutions
that referenced
this pull request
Jul 19, 2022
paskals
added a commit
to paskals/damn-vulnerable-defi
that referenced
this pull request
Aug 20, 2022
|
Thanks for the suggestion! I incorporated this in v3. |
soyccan
added a commit
to soyccan/damn-vulnerable-defi
that referenced
this pull request
Aug 12, 2023
soyccan
added a commit
to soyccan/damn-vulnerable-defi
that referenced
this pull request
Aug 12, 2023
soyccan
added a commit
to soyccan/damn-vulnerable-defi
that referenced
this pull request
Aug 12, 2023
pkqs90
added a commit
to pkqs90/damn-vulnerable-defi
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The puppet challenge expects the attackers balance to be greater than the initial pool balance.
https://github.com/tinchoabbate/damn-vulnerable-defi/blob/82b6049452c387235ee0b452b0de9f3dca88c072/test/puppet/puppet.challenge.js#L117
This is unlike puppet-v2 where the correct test is made.
https://github.com/tinchoabbate/damn-vulnerable-defi/blob/82b6049452c387235ee0b452b0de9f3dca88c072/test/puppet-v2/puppet-v2.challenge.js#L97
This leads to a more convoluted solution requiring either the attacker swap tokens more than once or only sell some of his tokens.