Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support device restart or kexec as part of workflows #29

Open
chrisdoherty4 opened this issue May 9, 2023 · 2 comments
Open

Support device restart or kexec as part of workflows #29

chrisdoherty4 opened this issue May 9, 2023 · 2 comments
Labels
status/accepted The scope and kind of work is agreed and the item accepted to the backlog theme/feature New functionality in Tinkerbell

Comments

@chrisdoherty4
Copy link
Member

chrisdoherty4 commented May 9, 2023

Summary

When provisioning devices users inevitably need to restart the device (or kexec). To date, users achieve a restart through an action which can lead to incorrect status reporting on Workflows.

When the restart action is run it instructs the kernel to perform a system restart. The restart process races against the action exiting and Tink Worker reporting the action was successful. In the case of kexec, we rarely - if ever - see the action transition to a success state. This generally leaves workflows to timeout which is misleading for users.

This issue is to track the introduction of restart/kexec to workflows as a built in feature removing the need to include an action. Other proposals are welcome.

@chrisdoherty4 chrisdoherty4 added theme/feature New functionality in Tinkerbell status/accepted The scope and kind of work is agreed and the item accepted to the backlog labels May 9, 2023
@dln
Copy link

dln commented May 15, 2023

We just ran into this when setting tinkerbell up. 😄

+1 for a specific "restart action", since that'll keep it OS independent as well.

@jacobweinstock
Copy link
Member

We might want to also add a power off builtin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/accepted The scope and kind of work is agreed and the item accepted to the backlog theme/feature New functionality in Tinkerbell
Projects
Status: Accepted
Development

No branches or pull requests

3 participants