Skip to content

Etna 797 #110

Merged
merged 15 commits into from
Oct 4, 2021
Merged

Etna 797 #110

merged 15 commits into from
Oct 4, 2021

Conversation

alex-hse-repository
Copy link
Collaborator

@alex-hse-repository alex-hse-repository commented Sep 28, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Add Clustering

Related Issue

Closing issues

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #110 (3ac73b1) into master (751347c) will increase coverage by 0.00%.
The diff coverage is 88.10%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #110    +/-   ##
========================================
  Coverage   88.05%   88.06%            
========================================
  Files          55       66    +11     
  Lines        2554     2865   +311     
========================================
+ Hits         2249     2523   +274     
- Misses        305      342    +37     
Impacted Files Coverage Δ
etna/clustering/distances/dtw_distance.py 69.31% <69.31%> (ø)
etna/clustering/base.py 83.33% <83.33%> (ø)
etna/clustering/distances/base.py 88.09% <88.09%> (ø)
etna/clustering/distances/distance_matrix.py 94.82% <94.82%> (ø)
etna/clustering/__init__.py 100.00% <100.00%> (ø)
etna/clustering/distances/__init__.py 100.00% <100.00%> (ø)
etna/clustering/distances/euclidean_distance.py 100.00% <100.00%> (ø)
etna/clustering/hierarchical/__init__.py 100.00% <100.00%> (ø)
etna/clustering/hierarchical/base.py 100.00% <100.00%> (ø)
etna/clustering/hierarchical/dtw_clustering.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751347c...3ac73b1. Read the comment docs.

@alex-hse-repository alex-hse-repository marked this pull request as ready for review September 29, 2021 11:08
@alex-hse-repository
Copy link
Collaborator Author

Note: The DistanceMatrix version for new architecture shows the same time as the old one in computing distance matrix

Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should add basic example to DTWClustering and EuclideanClustering class docstrings.
  • np.array to np.ndarray in type
  • check docsting for proper Result section. Sometimes typing is missing.

etna/clustering/base.py Outdated Show resolved Hide resolved
etna/clustering/base.py Outdated Show resolved Hide resolved
etna/clustering/base.py Outdated Show resolved Hide resolved
etna/clustering/distances/base.py Outdated Show resolved Hide resolved
etna/clustering/distances/base.py Outdated Show resolved Hide resolved
etna/clustering/distances/distance_matrix.py Outdated Show resolved Hide resolved
etna/clustering/distances/distance_matrix.py Outdated Show resolved Hide resolved
etna/clustering/distances/distance_matrix.py Outdated Show resolved Hide resolved
etna/clustering/hierarchical/base.py Show resolved Hide resolved
etna/clustering/hierarchical/base.py Outdated Show resolved Hide resolved
"""Compute distance matrix for given series."""
distances = np.empty(shape=(self.series_number, self.series_number))
logging_freq = self.series_number // 10
logger_id = tslogger.add(ConsoleLogger())
Copy link
Contributor

@martins0n martins0n Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't do this. Tslogger is as global object and all handlers've added already.
tslogger.start_experiment() and this too. Look at code examples https://github.com/tinkoff-ai/etna-ts/blob/51afbc2df6d046e3c2ab9b102f50fc7c83529f5a/etna/datasets/tsdataset.py#L122

Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants