-
Notifications
You must be signed in to change notification settings - Fork 80
Etna 797 #110
Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
========================================
Coverage 88.05% 88.06%
========================================
Files 55 66 +11
Lines 2554 2865 +311
========================================
+ Hits 2249 2523 +274
- Misses 305 342 +37
Continue to review full report at Codecov.
|
Note: The DistanceMatrix version for new architecture shows the same time as the old one in computing distance matrix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We should add basic example to DTWClustering and EuclideanClustering class docstrings.
- np.array to np.ndarray in type
- check docsting for proper
Result
section. Sometimes typing is missing.
"""Compute distance matrix for given series.""" | ||
distances = np.empty(shape=(self.series_number, self.series_number)) | ||
logging_freq = self.series_number // 10 | ||
logger_id = tslogger.add(ConsoleLogger()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't do this. Tslogger is as global object and all handlers've added already.
tslogger.start_experiment()
and this too. Look at code examples https://github.com/tinkoff-ai/etna-ts/blob/51afbc2df6d046e3c2ab9b102f50fc7c83529f5a/etna/datasets/tsdataset.py#L122
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Add Clustering
Related Issue
Closing issues