Skip to content

remove offset #111

Merged
merged 6 commits into from
Sep 29, 2021
Merged

remove offset #111

merged 6 commits into from
Sep 29, 2021

Conversation

WinstonDovlatov
Copy link
Contributor

@WinstonDovlatov WinstonDovlatov commented Sep 28, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

#98

Closing issues

#98

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #111 (356c4e8) into master (262fa68) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   88.04%   88.03%   -0.01%     
==========================================
  Files          55       55              
  Lines        2542     2541       -1     
==========================================
- Hits         2238     2237       -1     
  Misses        304      304              
Impacted Files Coverage Δ
etna/transforms/statistics.py 98.80% <ø> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262fa68...356c4e8. Read the comment docs.

@WinstonDovlatov WinstonDovlatov marked this pull request as ready for review September 28, 2021 16:50
@WinstonDovlatov WinstonDovlatov linked an issue Sep 28, 2021 that may be closed by this pull request
3 tasks
Copy link
Contributor

@julia-shenshina julia-shenshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@julia-shenshina
Copy link
Contributor

Add closes #98 to Closing issues block in PR description; it allows to close the corresponding issue automatically with PR merge

@julia-shenshina julia-shenshina merged commit ea2eb72 into master Sep 29, 2021
@iKintosh iKintosh deleted the fix_offset_statistics branch October 15, 2021 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete offset in WindowStatisticsTransform
3 participants