Categorical and fillna issues with pandas >=1.2 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 75 75
Lines 3453 3453
=======================================
Hits 3033 3033
Misses 420 420
Continue to review full report at Codecov.
|
iKintosh
approved these changes
Oct 13, 2021
| @@ -172,7 +172,7 @@ def transform(self, df: pd.DataFrame) -> pd.DataFrame: | |||
| ts = TSDataset(df, self.freq) | |||
| df_flat = ts.to_pandas(flatten=True) | |||
| df_flat = df_flat[df_flat.timestamp >= self.min_timestamp] | |||
| df_flat = df_flat.fillna(0) | |||
| df_flat["target"] = df_flat["target"].fillna(0) | |||
There was a problem hiding this comment.
Can you describe why is it necessary change?
There was a problem hiding this comment.
We can't fill columns with categorical types with pandas >=1.2 + fillna all -- is too strong assumption, because we mostly have nan's only in the future targets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Fillna only target values of DataFrame.
Related Issue
#162
Closing issues