Skip to content

Add interactive plot for anomalies #95

Merged
merged 8 commits into from
Sep 27, 2021
Merged

Add interactive plot for anomalies #95

merged 8 commits into from
Sep 27, 2021

Conversation

alex-hse-repository
Copy link
Collaborator

@alex-hse-repository alex-hse-repository commented Sep 24, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

@alex-hse-repository alex-hse-repository marked this pull request as ready for review September 27, 2021 06:36
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add example to docstrings? It's not obvious now how to call this function

etna/analysis/plotters.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2021

Codecov Report

Merging #95 (5548102) into master (3fd40e3) will decrease coverage by 1.02%.
The diff coverage is 14.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   88.72%   87.70%   -1.03%     
==========================================
  Files          54       54              
  Lines        2430     2464      +34     
==========================================
+ Hits         2156     2161       +5     
- Misses        274      303      +29     
Impacted Files Coverage Δ
etna/analysis/plotters.py 13.97% <12.12%> (-0.60%) ⬇️
etna/analysis/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd40e3...5548102. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n merged commit ebed9c9 into master Sep 27, 2021
@martins0n martins0n deleted the ETNA-790 branch September 27, 2021 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants