Skip to content

Create BottomUpReconciler #1037

Closed
alex-hse-repository opened this issue Dec 12, 2022 · 0 comments
Closed

Create BottomUpReconciler #1037

alex-hse-repository opened this issue Dec 12, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@alex-hse-repository
Copy link
Collaborator

alex-hse-repository commented Dec 12, 2022

🚀 Feature Request

Create reconciler implementing Bottom-Up approach

Proposal

  1. Create class BottomUpReconciler(BaseReconciler)
  • Check that source_level is lower than target_level
  1. Implement method fit:
    • Receive dataset on the the level which is lower or equal than target_level, source_level
    • Aggregate the dataset to the source_level
    • Set mapping matrix as summing matrix from source to target level

Test cases

  • Test constructor works correctly with different source and target levels
  • Test method fit saves the correct matrix in mapping_matrix for different source/target levels
    • source=target
    • source<target
    • source>target

Additional context

No response

@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Dec 12, 2022
@alex-hse-repository alex-hse-repository moved this to Specification in etna board Dec 12, 2022
@alex-hse-repository alex-hse-repository moved this from Specification to Backlog in etna board Dec 16, 2022
@brsnw250 brsnw250 self-assigned this Dec 30, 2022
@brsnw250 brsnw250 moved this from Backlog to In Progress in etna board Dec 30, 2022
@brsnw250 brsnw250 moved this from In Progress to In Review in etna board Dec 30, 2022
@brsnw250 brsnw250 closed this as completed Jan 3, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants