Skip to content

Create TopDownReconciliator #1038

Closed
alex-hse-repository opened this issue Dec 12, 2022 · 0 comments
Closed

Create TopDownReconciliator #1038

alex-hse-repository opened this issue Dec 12, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@alex-hse-repository
Copy link
Collaborator

alex-hse-repository commented Dec 12, 2022

🚀 Feature Request

Create reconciler implementing Top-Down approaches

Proposal

  1. Create class TopDownReconciliator(BaseReconciler)
  • T: int -- length of the lookback window
  • method: str -- "AHP"/"PHA" = "Average historical proportions"/"Proportions of the historical averages" (might be implemented via enum)
  • Check that source_level is upper than target_level
  1. Implement method fit:
    • Receive dataset on the the level which is lower or equal than target_level, source_level
    • Aggregate the dataset to the source_level
    • Fit the mapping_matrix: G[i,j] - 0, if there is no path between i and j. Otherwise use formula form here according to the method.
    • It should be a sparce matrix

Test cases

  • Test constructor works correctly with different source and target levels
    • source=target
    • source<target
    • source>target
  • Method fit generates correct mapping matrix for
    • Different target/source
    • Different tree structure
    • Different T
    • Different method

Additional context

No response

@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Dec 12, 2022
@alex-hse-repository alex-hse-repository moved this to Specification in etna board Dec 12, 2022
@alex-hse-repository alex-hse-repository changed the title Create TopDownAverageHistoricalProportionsReconciler Create TopDownReconciler Dec 12, 2022
@alex-hse-repository alex-hse-repository moved this from Specification to Backlog in etna board Dec 16, 2022
@brsnw250 brsnw250 self-assigned this Dec 26, 2022
@brsnw250 brsnw250 moved this from Backlog to In Progress in etna board Dec 26, 2022
@martins0n martins0n moved this from In Progress to In Review in etna board Dec 29, 2022
@brsnw250 brsnw250 changed the title Create TopDownReconciler Create TopDownReconciliator Dec 29, 2022
@brsnw250 brsnw250 moved this from In Review to Done in etna board Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants