Skip to content

Add default params_to_tune for missing values transforms #1224

Closed
Mr-Geekman opened this issue Apr 14, 2023 · 1 comment
Closed

Add default params_to_tune for missing values transforms #1224

Mr-Geekman opened this issue Apr 14, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Mr-Geekman
Copy link
Contributor

Mr-Geekman commented Apr 14, 2023

🚀 Feature Request

Add default params_to_tune for missing values transforms.

Proposal

Suggested grid for ResampleWithDistributionTransform: None. Because it isn't used for improving quality.

Suggested grid for TimeSeriesImputerTransform
if seasonality == 1:

{
    "strategy": CategoricalDistribution(["constant", "mean", "running_mean", "forward_fill"]),
    "window": IntUniformDistribution(low=1, high=20)
}

if seasonality > 1:

{
    "strategy": CategoricalDistribution(["constant", "mean", "running_mean", "forward_fill", "seasonal"]),
    "window": IntUniformDistribution(low=1, high=20)
}

To discuss:

  • Can we somehow add "seasonal" to strategy? It requires some knowledge about the frequency. We can also tune window in this case.

Test cases

Look at #1221. Check empty grid as well.

Additional context

No response

@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Apr 14, 2023
@Mr-Geekman Mr-Geekman added this to the AutoML 2.0 milestone Apr 14, 2023
@github-project-automation github-project-automation bot moved this to Specification in etna board Apr 14, 2023
@Mr-Geekman Mr-Geekman moved this from Specification to Todo in etna board Apr 14, 2023
@Mr-Geekman Mr-Geekman self-assigned this Apr 19, 2023
@Mr-Geekman Mr-Geekman moved this from Todo to In Progress in etna board Apr 19, 2023
@Mr-Geekman Mr-Geekman moved this from In Progress to In Review in etna board Apr 19, 2023
@Mr-Geekman
Copy link
Contributor Author

Closed by #1232.

@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant