Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): TUI_AVATAR_OPTIONS default options configuration for Avatar #1600

Merged
merged 4 commits into from
Apr 8, 2022
Merged

feat(kit): TUI_AVATAR_OPTIONS default options configuration for Avatar #1600

merged 4 commits into from
Apr 8, 2022

Conversation

zarghamkhandev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Partially implements #133

What is the new behavior?

Default avatar options can be set via a provider. This is a partial implementation of #133

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Apr 6, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Member

@nsbarsukov nsbarsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!

projects/kit/components/avatar/avatar-options.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1600 (afead3d) into main (2775ac0) will increase coverage by 1.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1600      +/-   ##
==========================================
+ Coverage   61.98%   63.15%   +1.17%     
==========================================
  Files         693      913     +220     
  Lines        8478    10012    +1534     
  Branches     1657     1927     +270     
==========================================
+ Hits         5255     6323    +1068     
- Misses       2816     3247     +431     
- Partials      407      442      +35     
Flag Coverage Δ
addon-charts 74.69% <ø> (ø)
addon-doc 26.15% <ø> (ø)
addon-editor 45.87% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 81.39% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 69.52% <ø> (?)
core 67.46% <ø> (ø)
kit 62.96% <100.00%> (+0.04%) ⬆️
summary 63.15% <100.00%> (+1.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/components/avatar/avatar-options.ts 100.00% <100.00%> (ø)
projects/kit/components/avatar/avatar.component.ts 95.23% <100.00%> (+0.23%) ⬆️
projects/cdk/date-time/date-format.ts 50.00% <0.00%> (ø)
projects/cdk/pipes/mapper/mapper.module.ts 100.00% <0.00%> (ø)
projects/cdk/enums/month-number.ts 100.00% <0.00%> (ø)
projects/cdk/utils/dom/is-current-target.ts 100.00% <0.00%> (ø)
projects/cdk/abstract/control.ts 5.79% <0.00%> (ø)
projects/cdk/directives/pressed/pressed.module.ts 100.00% <0.00%> (ø)
projects/cdk/exceptions/value-changes.exception.ts 100.00% <0.00%> (ø)
projects/cdk/tokens/sanitizer.ts 100.00% <0.00%> (ø)
... and 211 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2775ac0...afead3d. Read the comment docs.

@splincode
Copy link
Member

Hello, please, rebase with main branch before

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

@waterplea waterplea merged commit ff4dc30 into taiga-family:main Apr 8, 2022
@well-done-bot
Copy link

well-done-bot bot commented Apr 8, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants