Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): provide default status when async pipe isn't emitted #1605

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

@lumberjack-bot
Copy link

lumberjack-bot bot commented Apr 7, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

Visit the preview URL for this PR (updated for commit 5a8a3dd):

https://taiga-ui--pr1605-splincode-fix-kit-26fx7n40.web.app

(expires Fri, 08 Apr 2022 11:28:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1605 (5a8a3dd) into main (4703f1c) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #1605   +/-   ##
=======================================
  Coverage   61.98%   61.98%           
=======================================
  Files         693      693           
  Lines        8478     8478           
  Branches     1657     1657           
=======================================
  Hits         5255     5255           
  Misses       2816     2816           
  Partials      407      407           
Flag Coverage Δ
addon-charts 74.69% <ø> (ø)
addon-doc 26.15% <ø> (ø)
addon-editor 45.87% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 81.39% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
core 67.46% <ø> (ø)
kit 62.92% <50.00%> (ø)
summary 61.98% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/kit/components/input-tag/input-tag.component.ts 70.55% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4703f1c...5a8a3dd. Read the comment docs.

@splincode splincode merged commit 46bda8b into main Apr 7, 2022
@splincode splincode deleted the splincode/fix/kit branch April 7, 2022 12:54
@well-done-bot
Copy link

well-done-bot bot commented Apr 7, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants