Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): Slider readonly state (mobile chrome bug) #1638

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Apr 15, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

  1. Use mobile chrome
  2. Open https://taiga-ui.dev/components/range
  3. Try change value of Range
[Intervention] Ignored attempt to cancel a touchstart event with cancelable=false,
for example because scrolling is in progress and cannot be interrupted.

What is the new behavior?

New version of SliderReadonlyDirective.

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Apr 15, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2022

Visit the preview URL for this PR (updated for commit 3d2c8b2):

https://taiga-ui--pr1638-slider-readonly-fix-bpi7noqq.web.app

(expires Tue, 26 Apr 2022 12:27:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@nsbarsukov nsbarsukov force-pushed the slider-readonly-fix branch 2 times, most recently from 963961a to 44a95aa Compare April 19, 2022 09:24
@nsbarsukov nsbarsukov force-pushed the slider-readonly-fix branch 3 times, most recently from 2dca55f to 085cc96 Compare April 19, 2022 11:27
@nsbarsukov nsbarsukov merged commit 0669a71 into main Apr 25, 2022
@nsbarsukov nsbarsukov deleted the slider-readonly-fix branch April 25, 2022 13:22
@well-done-bot
Copy link

well-done-bot bot commented Apr 25, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants