-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kit): Slider
readonly state (mobile chrome bug)
#1638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsbarsukov
requested review from
waterplea,
MarsiBarsi and
vladimirpotekhin
as code owners
April 15, 2022 14:11
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit 3d2c8b2): https://taiga-ui--pr1638-slider-readonly-fix-bpi7noqq.web.app (expires Tue, 26 Apr 2022 12:27:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
splincode
reviewed
Apr 15, 2022
splincode
reviewed
Apr 15, 2022
splincode
approved these changes
Apr 15, 2022
nsbarsukov
force-pushed
the
slider-readonly-fix
branch
from
April 15, 2022 14:41
3eb0bbc
to
7bee77d
Compare
splincode
reviewed
Apr 15, 2022
nsbarsukov
force-pushed
the
slider-readonly-fix
branch
2 times, most recently
from
April 19, 2022 09:24
963961a
to
44a95aa
Compare
splincode
reviewed
Apr 19, 2022
nsbarsukov
force-pushed
the
slider-readonly-fix
branch
3 times, most recently
from
April 19, 2022 11:27
2dca55f
to
085cc96
Compare
nsbarsukov
force-pushed
the
slider-readonly-fix
branch
from
April 25, 2022 12:23
085cc96
to
3d2c8b2
Compare
waterplea
approved these changes
Apr 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Range
What is the new behavior?
New version of
SliderReadonlyDirective
.Does this PR introduce a breaking change?