Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): Pagination & Preview show undefined for title #1642

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Pagination
pagination

Preview
preview

What is the new behavior?

Pagination
pagination-new

Preview
preview-new

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Apr 18, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 7e28bc4):

https://taiga-ui--pr1642-pagination-title-tex-ujo1f7tk.web.app

(expires Tue, 19 Apr 2022 07:22:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@nsbarsukov nsbarsukov merged commit 7158630 into main Apr 18, 2022
@nsbarsukov nsbarsukov deleted the pagination-title-texts branch April 18, 2022 08:57
@well-done-bot
Copy link

well-done-bot bot commented Apr 18, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants