Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Lists add triangle bullet list type #1727

Merged
merged 3 commits into from
May 6, 2022

Conversation

n1k1t0ss
Copy link
Contributor

@n1k1t0ss n1k1t0ss commented May 5, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Tinkoff add new core style for bullet list - it appears as triangle - "◤" but taiga doesn't have it.

What is the new behavior?

Adds new style without changing others. It has same usage as regular linear: <ul class="tui-list tui-list_triangle">

Screenshot_89

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 5, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Member

@nsbarsukov nsbarsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you, please add example of new list to
https://taiga-ui.dev/lists ?

projects/core/styles/markup/tui-list.less Outdated Show resolved Hide resolved
projects/core/styles/markup/tui-list.less Outdated Show resolved Hide resolved
@n1k1t0ss n1k1t0ss requested a review from nsbarsukov May 6, 2022 09:47
@nsbarsukov nsbarsukov changed the title style(tui-list): add triangle bullet list type feat(core): Lists add triangle bullet list type May 6, 2022
@nsbarsukov nsbarsukov merged commit b189a67 into taiga-family:main May 6, 2022
@well-done-bot
Copy link

well-done-bot bot commented May 6, 2022

'Well done'

@n1k1t0ss n1k1t0ss deleted the triangle-bullets branch May 6, 2022 14:45
@tinkoff-bot tinkoff-bot mentioned this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants