Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): tui-slider-ticks-labels error Operation on an invalid type #1759

Merged
merged 1 commit into from
May 16, 2022

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented May 16, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Use Angular 13

.some-class {
  .tui-slider-ticks-labels();
^
Operation on an invalid type
      Error in .../.../app.component.less

What is the new behavior?

See Less documentation:

In order to cause fewer conflicts with CSS, which now liberally uses the / symbol between values, there is now a math mode that only requires parentheses for division. (This is now the default in Less 4.) "Strict math" has also been tweaked to operate more intuitively, although the legacy behavior is supported.

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 16, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 31fce51):

https://taiga-ui--pr1759-slider-parentheses-d-6u3w0q9t.web.app

(expires Tue, 17 May 2022 08:25:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1759 (31fce51) into main (c3593a2) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1759      +/-   ##
==========================================
+ Coverage   63.17%   63.19%   +0.01%     
==========================================
  Files         923      923              
  Lines       10036    10041       +5     
  Branches     1939     1939              
==========================================
+ Hits         6340     6345       +5     
  Misses       3245     3245              
  Partials      451      451              
Flag Coverage Δ
addon-charts 74.42% <ø> (ø)
addon-doc 25.82% <ø> (ø)
addon-editor 45.87% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 81.39% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 69.63% <ø> (+0.09%) ⬆️
core 67.48% <ø> (ø)
kit 63.04% <ø> (ø)
summary 63.19% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/cdk/date-time/month.ts 100.00% <0.00%> (ø)
projects/cdk/date-time/time.ts 97.95% <0.00%> (+0.08%) ⬆️
projects/cdk/date-time/year.ts 97.05% <0.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3593a2...31fce51. Read the comment docs.

@nsbarsukov nsbarsukov merged commit 9c3521e into main May 16, 2022
@nsbarsukov nsbarsukov deleted the slider-parentheses-division branch May 16, 2022 09:10
@well-done-bot
Copy link

well-done-bot bot commented May 16, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants