-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk): refactor autofill directive #1775
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit a383428): https://taiga-ui--pr1775-splincode-bugfix-iss-ydzrpwi9.web.app (expires Sat, 21 May 2022 17:04:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
2d8a555
to
dc01b61
Compare
ac77796
to
ebd8e70
Compare
ebd8e70
to
c61de23
Compare
c61de23
to
4059975
Compare
Codecov Report
@@ Coverage Diff @@
## main #1775 +/- ##
==========================================
+ Coverage 63.17% 63.25% +0.07%
==========================================
Files 930 931 +1
Lines 10050 10052 +2
Branches 1943 1945 +2
==========================================
+ Hits 6349 6358 +9
+ Misses 3251 3240 -11
- Partials 450 454 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
b554ab7
to
8557310
Compare
projects/core/components/primitive-textfield/primitive-textfield.style.less
Outdated
Show resolved
Hide resolved
a34ceb2
to
8867bde
Compare
8867bde
to
8e61328
Compare
host: { | ||
class: 'tui-autofill', | ||
}, | ||
host: {class: 'tui-autofill'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we no longer need this class, do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, transition: box-shadow 0.01s;
we need to define rules only for those elements who input.tui-autofill
or .tui-autofill input
}) | ||
export class TuiAutofilledDirective { | ||
@HostBinding('class._autofilled') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this doesn't do anything, we add this class on host in PrimitiveTextfield
and styles rely on it being there, not here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<input (tuiAutofillChanges)="next.emit($event)">
But it would be great for us to add a class to the host to determine that it is autofilled.
_autofilled
- system css class looks like _focused
, etc
8e61328
to
a383428
Compare
@nsbarsukov hello, please review me) |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #1679 #1785
What is the new behavior?
Screen.Recording.2022-05-18.at.19.23.36.mov
Does this PR introduce a breaking change?