Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-table): add token TUI_TABLE_PAGINATION_OPTIONS with property sizeOptionContent #1787

Merged
merged 2 commits into from
May 20, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #UIKIT-5784

What is the new behavior?

2-[sizeOptionContent]-dropdown.snap.png:
2- sizeOptionContent -dropdown snap

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 20, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #1787 (c5b5767) into main (5097094) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #1787   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files         922      923    +1     
  Lines       10025    10031    +6     
  Branches     1941     1941           
=======================================
+ Hits         6348     6352    +4     
- Misses       3227     3229    +2     
  Partials      450      450           
Flag Coverage Δ
addon-charts 74.42% <ø> (ø)
addon-doc 26.73% <ø> (ø)
addon-editor 45.87% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 79.59% <66.66%> (-1.81%) ⬇️
addon-tablebars ∅ <ø> (∅)
cdk 69.63% <ø> (ø)
core 67.78% <ø> (ø)
kit 63.16% <ø> (ø)
summary 63.32% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onents/table-pagination/table-pagination.module.ts 100.00% <ø> (ø)
...nents/table-pagination/table-pagination-options.ts 60.00% <60.00%> (ø)
...nts/table-pagination/table-pagination.component.ts 84.61% <100.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5097094...c5b5767. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2022

Visit the preview URL for this PR (updated for commit c5b5767):

https://taiga-ui--pr1787-table-pagination-siz-manacb7b.web.app

(expires Sat, 21 May 2022 14:24:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@nsbarsukov nsbarsukov force-pushed the table-pagination-size-option-content branch from af590c9 to 3943f84 Compare May 20, 2022 12:47
@waterplea waterplea merged commit af7a82b into main May 20, 2022
@waterplea waterplea deleted the table-pagination-size-option-content branch May 20, 2022 16:02
@well-done-bot
Copy link

well-done-bot bot commented May 20, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants