Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-editor): add details extension #1814

Merged
merged 6 commits into from
May 30, 2022
Merged

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #1645

What is the new behavior?

2022-05-25.18.38.34.mov

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 25, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2022

Visit the preview URL for this PR (updated for commit de884d3):

https://taiga-ui--pr1814-editor-toggle-59xslvnn.web.app

(expires Tue, 31 May 2022 11:02:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #1814 (de884d3) into main (110c921) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1814   +/-   ##
=======================================
  Coverage   63.25%   63.26%           
=======================================
  Files         934      934           
  Lines       10081    10082    +1     
  Branches     1948     1948           
=======================================
+ Hits         6377     6378    +1     
  Misses       3250     3250           
  Partials      454      454           
Flag Coverage Δ
addon-charts 74.42% <ø> (ø)
addon-doc 26.73% <ø> (ø)
addon-editor 45.97% <100.00%> (+0.10%) ⬆️
addon-mobile ∅ <ø> (∅)
addon-table 79.59% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 69.11% <ø> (ø)
core 67.99% <ø> (ø)
kit 63.04% <ø> (ø)
summary 63.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cts/addon-editor/constants/default-editor-tools.ts 100.00% <ø> (ø)
...cts/addon-editor/constants/tiptap-editor-styles.ts 100.00% <ø> (ø)
projects/addon-editor/enums/editor-tool.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 110c921...de884d3. Read the comment docs.

Copy link
Member

@nsbarsukov nsbarsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safari. Desktop
safariDesktop

@vladimirpotekhin
Copy link
Member Author

vladimirpotekhin commented May 26, 2022

Safari. Desktop

:sofare: fixed

@vladimirpotekhin vladimirpotekhin force-pushed the editor-toggle branch 2 times, most recently from b51a772 to 30ccadb Compare May 26, 2022 09:37
@vladimirpotekhin vladimirpotekhin deleted the editor-toggle branch May 30, 2022 11:15
@well-done-bot
Copy link

well-done-bot bot commented May 30, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - Add an accordion component
4 participants