Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): new TuiNumberFormatSettings instead of deprecated NumberFormatSettings #1886

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jun 9, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Visit the preview URL for this PR (updated for commit 0a9c73e):

https://taiga-ui--pr1886-number-format-settin-a02tpn4c.web.app

(expires Fri, 10 Jun 2022 09:14:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1886 (0a9c73e) into main (7b303d1) will not change coverage.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main    #1886   +/-   ##
=======================================
  Coverage   63.08%   63.08%           
=======================================
  Files         934      934           
  Lines       10122    10122           
  Branches     1960     1960           
=======================================
  Hits         6385     6385           
  Misses       3276     3276           
  Partials      461      461           
Flag Coverage Δ
addon-charts 74.50% <100.00%> (ø)
addon-doc 26.68% <ø> (ø)
addon-editor 45.97% <ø> (ø)
addon-mobile ?
addon-table 79.59% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 67.92% <ø> (ø)
core 67.95% <50.00%> (ø)
kit 63.04% <100.00%> (ø)
summary 63.08% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cts/core/pipes/format-number/format-number.pipe.ts 14.28% <0.00%> (ø)
...e/utils/mask/enable-auto-correct-decimal-symbol.ts 0.00% <ø> (ø)
...addon-commerce/components/money/money.component.ts 100.00% <100.00%> (ø)
projects/core/tokens/number-format.ts 50.00% <100.00%> (ø)
...it/components/input-count/input-count.component.ts 75.00% <100.00%> (ø)
.../components/input-number/input-number.component.ts 70.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b303d1...0a9c73e. Read the comment docs.

@nsbarsukov nsbarsukov merged commit bda8f5a into main Jun 10, 2022
@nsbarsukov nsbarsukov deleted the number-format-settings-interface branch June 10, 2022 09:11
@well-done-bot
Copy link

well-done-bot bot commented Jun 10, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants