From ce19add3ba9bf4172bea206fe8c733848b68a1fb Mon Sep 17 00:00:00 2001 From: Adam Friedman Date: Fri, 20 Apr 2018 15:58:36 +1000 Subject: [PATCH] Don't display hover tip for a target when hovering on one of its (child) task elements. tintoy/msbuild-project-tools-server#5 --- src/LanguageServer.Engine/Handlers/HoverHandler.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/LanguageServer.Engine/Handlers/HoverHandler.cs b/src/LanguageServer.Engine/Handlers/HoverHandler.cs index a5ab742..8126af5 100644 --- a/src/LanguageServer.Engine/Handlers/HoverHandler.cs +++ b/src/LanguageServer.Engine/Handlers/HoverHandler.cs @@ -189,7 +189,10 @@ async Task OnHover(TextDocumentPositionParams parameters, CancellationTok } case MSBuildTarget target: { - hoverContent = contentProvider.Target(target); + // Currently (and this is a bug), an MSBuildTarget is returned by MSBuildLocator when the location being inspected + // is actually on one of its child (task) elements. + if (element.Path == WellKnownElementPaths.Target) + hoverContent = contentProvider.Target(target); break; }