allow Edge on Linux but skip tests

titusfortner · Oct 14, 2021 · 34d04f2 · 34d04f2
1 parent 35ef673
commit 34d04f2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/lib/webdrivers/edgedriver.rb b/lib/webdrivers/edgedriver.rb
@@ -76,15 +76,15 @@ def apple_m1_compatible?(driver_version)
         false
       end
 
-      # def linux_compatible?(driver_version)
-      #   System.platform == 'linux' && driver_version >= normalize_version('89.0.731.0')
-      # end
+      def linux_compatible?(driver_version)
+        System.platform == 'linux' && driver_version >= normalize_version('89.0.731.0')
+      end
 
       def driver_filename(driver_version)
         if System.platform == 'win' || System.wsl_v1?
           "win#{System.bitsize}" # 32 or 64-bit
-        # elsif linux_compatible?(driver_version)
-        #   'linux64'
+        elsif linux_compatible?(driver_version)
+          'linux64'
         elsif System.platform == 'mac'
           # Determine M1 or Intel architecture
           apple_arch = apple_m1_compatible?(driver_version) ? 'arm' : 'mac'

diff --git a/spec/webdrivers/edge_finder_spec.rb b/spec/webdrivers/edge_finder_spec.rb
@@ -7,7 +7,9 @@
 
   before(:all) do # rubocop:disable RSpec/BeforeAfterAll
     if Selenium::WebDriver::VERSION[0].to_i < 4
-      skip "The current selenium-webdriver doesn't include Chromium based Edge support"
+      skip 'The current selenium-webdriver does not include Chromium based Edge support'
+    elsif Webdrivers::System.platform == 'linux'
+      skip 'Edge is not yet supported on Linux'
     end
   end
 

diff --git a/spec/webdrivers/edgedriver_spec.rb b/spec/webdrivers/edgedriver_spec.rb
@@ -7,7 +7,9 @@
 
   before(:all) do # rubocop:disable RSpec/BeforeAfterAll
     if Selenium::WebDriver::VERSION[0].to_i < 4
-      skip "The current selenium-webdriver doesn't include Chromium based Edge support"
+      skip 'The current selenium-webdriver does not include Chromium based Edge support'
+    elsif Webdrivers::System.platform == 'linux'
+      skip 'Edge is not yet supported on Linux'
     end
   end