feat: replacing missing css.fooga with stringified version #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
tivac
force-pushed
the
svelte-missing-classes
branch
from
1573de6
to
0537aac
Compare
So that there's less JS errors and it's easier to fix up the broken things. BREAKING CHANGE: Previously missing css.fooga references would be left as-is, now they're wrapped in quotes to prevent them from causing JS errors. If you want missing classes to break things you should enable strict mode.
So that if you have {css.nope} but no <link> or <style> it still becomes "css.nope".
Just for completeness sake, mostly
... and all the snapshots that use that output
Now that <script> isn't injected any more
tivac
force-pushed
the
svelte-missing-classes
branch
from
0537aac
to
6e4d2c7
Compare
|
Hey @tivac, TravisCI finished with status TravisBuddy Request Identifier: f9517d70-5158-11e9-ad12-835a6074a428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a
{css.fooga}reference (or justcss.foogain<script>blocks) is found, it's now replaced with"css.fooga".Motivation and Context
So that svelte generates less code and the code it does generate doesn't explode. There's still
strictmode if you want explosions though!This helps #571 but I'm not sure it fixes it completely.
How Has This Been Tested?
Added tests!
Types of changes
Checklist: