-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove true-case-path #582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new `dupewarn` option (that defaults to `true`) that will warn about files with the same path that only differ in case, because that's probably a bug!
Also update 📷 based on new chunk names
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
==========================================
+ Coverage 98.9% 98.92% +0.01%
==========================================
Files 47 48 +1
Lines 1191 1211 +20
Branches 183 184 +1
==========================================
+ Hits 1178 1198 +20
Misses 13 13
Continue to review full report at Codecov.
|
Let consumers do that instead, they can provide better errors anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing
true-case-path
package from@modular-css/processor
and replaced it with a newdupewarn
option that defaults to true.Motivation and Context
Fixes #581, adding a warning and removing the checks entirely is simpler and reasonably safe for all the cases that caused
true-case-path
to be added in the first place (#191, #527)How Has This Been Tested?
Added tests to make sure the warning correctly triggers and can be disabled.
Types of changes
Checklist:
THIS IS A BREAKING CHANGE