Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rewriter): don't explode on external chunks #749

Merged
merged 1 commit into from
Apr 21, 2020
Merged

fix(rewriter): don't explode on external chunks #749

merged 1 commit into from
Apr 21, 2020

Conversation

tivac
Copy link
Owner

@tivac tivac commented Apr 21, 2020

Description

Check to make sure a chunk is actually a thing before trying to read assets off of it.

Motivation and Context

How Has This Been Tested?

Fixes #688

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tivac tivac force-pushed the rewriter-tolerates-externals branch from abbd10f to 064cf36 Compare April 21, 2020 20:20
@tivac tivac merged commit be741bb into master Apr 21, 2020
@tivac tivac deleted the rewriter-tolerates-externals branch April 21, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rollup-rewriter doesn't handle unknown deps well
1 participant
@tivac