Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svelte): warn on non ".css" <link href> #766

Merged
merged 4 commits into from
Jun 21, 2020
Merged

feat(svelte): warn on non ".css" <link href> #766

merged 4 commits into from
Jun 21, 2020

Conversation

tivac
Copy link
Owner

@tivac tivac commented Jun 20, 2020

Description

Handling before errors and re-throwing with a more descriptive title, plus updated tests to match and removed a bunch of test cruft in the process.

Motivation and Context

#764

How Has This Been Tested?

Added tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Handling before errors and re-throwiing with a more descriptive title, plus updated tests to match and removed a bunch of test cruft in the process.
@tivac tivac added the feature label Jun 20, 2020
@tivac tivac self-assigned this Jun 20, 2020
@tivac tivac changed the title More useful parsing errors feat(svelte): warn on non ".css" <link href> Jun 21, 2020
@tivac tivac merged commit 1ac0e4d into master Jun 21, 2020
@tivac tivac deleted the svelte-non-css branch June 21, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant