-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add support for previous_sha and current_sha outputs #2371
Comments
Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience. |
Hi @gm42 , can you provide some more details about your use case? |
@jackton1 sure: one example is that after running this action one might want to put the used hashes in a text report telling about which files changed, or call |
Hi @gm4, okay I’d suggest taking a look at https://github.com/nrwl/nx-set-shas which covers your use case. Since this action primary focus is to retrieve changed files. |
Thanks for your answer; I disagree, that action is overkill for this and does not serve the purpose: this action is already deciding which commit SHAs to use, so by using a different action they could be different. I will use a fork, no problem. |
Is this feature missing in the latest version?
Is your feature request related to a problem? Please describe.
Not related to a problem. I have seen that the action text output tells about which SHAs were used for the comparison:
This corresponds to this line of code: https://github.com/tj-actions/changed-files/blob/05f0aba931687dcad284e6c7f2e049c258a53fb8/src/main.ts#L131C46-L131C57
Describe the solution you'd like?
It would be great if I could extract these values via
outputs
, to re-use them in other steps.Describe alternatives you've considered?
One can use
${{ github.event.pull_request.base.sha }}
and${{ github.event.pull_request.head.sha }}
instead.Anything else?
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: