It causes unexpected result if arguments are the same as option name

[zlargon]

This issue is quite similar to #471.

var program = require('commander');

program
  .option('-f, --foo', 'add some foo')
  .parse(['node', './test.js', 'foo']);

console.log(program.args);  // program.args = []
console.log(program.foo);   // program.foo = []

// Expected Result:
// program.args = ['foo']
// program.foo = undefined

[SomeKittens]

I'm not quite ready to say this is a dupe of #471, as 'version' is somewhat internal, and you've added foo.

[ericuldall]

The bug is with Command.prototype.parseOptions:

When looping over the options passed it accepts any values. It should perhaps only accept values that .match(/^-.*/)

[ericuldall]

I've added a fix proposal to pull request #517

[ericuldall]

The "fix" seems to be breaking other features, per failed unit tests. I'm not sure what or why at this point. Once the two play nice it should be useable.

[ericuldall]

It looks like many of the unit tests don't work when this functionality is fixed. Many of them pass options that are not defined as .option. So now the tests are throwing the error:

error: unknown option `--setup_mode'

To me, this seems like the correct behavior, though these will not pass a travis-ci build.

[shadowspawn]

Closing as duplicate of #346