-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0 Tracking Branch #77
Conversation
Ok, I just published a pre-release version if anyone wants to start testing this work.
Unfortunately, I also forgot about the silly behavior of npm where a new install will pull pre-release versions on the |
Following closely as we're about to start a big node api re-write. |
Ok, I think the bulk of the work is done here. I have feature additions that I want to work on, like testing and verifying migrations, but those can be added as minor points releases so we don't hold this any longer. Can a few people take a look and make sure I didn't overlook anything major? Maybe run a through a few example use cases or something? If I don't hear back I will pull the trigger sometime this weekend on the |
@wesleytodd It seems the |
I will update that package when a patch is available. But TBQH, I am not worried about a ReDOS vouln, because if you are creating migrations from untrusted sources you have bigger problems ;) But thanks for the report @dastoori. |
Published |
It works for me 👍 |
- Cleaned up main export - Added --clean - Added migrate list - Switched to timestamp and title migration tracking - Moved the migrations file out of the migrations directory - Added store init method - Added generator template option
Published!! |
🎉 🚀 Great work! |
To follow up, I just published Fixed here: dodo/node-slug#82 |
This PR will track the
1.x
release progress. Unfortunately I didn't plan on the amount of time from when I started merging those PR's from the fork. So I rolled back the master branch here to the last release (0.2.3
). This now contains what I will start publishing as the release candidates for1.x
.Current known issues (will open separate tickets to track them if I don't fix them this weekend):
Missing docs on all the new features and changes(Docs written now)Cases where migrations are merged out of the order they are created are still not handled correctly(will warn users if this happens)Migrations listed in the state file but not in the migrations directory not handled(an error occurs in this case)Integrate support for dotenv #85Error when no promise or callback provided #86