Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to proxy multiple ECR registries at once #6

Open
james-callahan opened this issue Jun 16, 2023 · 2 comments
Open

Ability to proxy multiple ECR registries at once #6

james-callahan opened this issue Jun 16, 2023 · 2 comments

Comments

@james-callahan
Copy link
Contributor

Currently ecr-proxy takes a single ECR repo to proxy via a command line argument.

This means to access different ECR registries a user needs to run multiple instances of ecr-proxy.

Instead, could you proxy to different accounts/registries based on e.g. a Host header?

@Ulexus
Copy link
Collaborator

Ulexus commented Jun 16, 2023

Surely, but this is an extremely lightweight appliance. Why would you want to complicate the one instead of deploying multiple instances? When rubbing in a kubernetes environment (as it's planned, no?), I would generally prefer a micro services approach anyway.

It's also not just a concern of reading the host header. We would also need to have a whitelist to prevent us from being an open proxy.

@james-callahan
Copy link
Contributor Author

Why would you want to complicate the one instead of deploying multiple instances?

Each instance run needs its own resources for base load as well as peak limits.
Going further: for multi-availability-zone scenarios, to lower interAZ networking costs you'd likely want to run it in each AZ.
I see this as a growing waste of resources that could be fixed if you handled multiple registries at once.

It's also not just a concern of reading the host header. We would also need to have a whitelist to prevent us from being an open proxy.

Yeah I would expect a configuration like: --accounts ecr-proxy-development.ecr-proxy.svc:123456789,ecr-proxy-production.ecr-proxy.svc:987654321 where you map specific hosts to specific ecr registries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants