Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement protobuf wire protocol and get rid that dependency #5

Closed
tkowalcz opened this issue Nov 15, 2020 · 0 comments · Fixed by #30
Closed

Implement protobuf wire protocol and get rid that dependency #5

tkowalcz opened this issue Nov 15, 2020 · 0 comments · Fixed by #30
Labels
core Relates to Core component

Comments

@tkowalcz
Copy link
Owner

Protobuf increases size of the release jar and has inefficient API that forces us to allocate a lot of Strings. We need to create protobuf message template with enough logic that we can send valid Loki updates without depending on protobuf itself.
@tkowalcz tkowalcz added the core Relates to Core component label Nov 15, 2020
tkowalcz added a commit that referenced this issue Jan 25, 2021
@tkowalcz
Re #5: Initial stab at implementing in-house protobuf serialzier. Loo…
07bf4b8 
…ks like it works.
tkowalcz added a commit that referenced this issue Feb 6, 2021
@tkowalcz
Re #5: Working on in house protobuf serialisation and reducing alloca…
4c375dd 
…tions.
tkowalcz added a commit that referenced this issue Feb 6, 2021
@tkowalcz
Re #5: Further progress. Fixed/updated tests. All but one pass.
a313b45
tkowalcz added a commit that referenced this issue Feb 6, 2021
@tkowalcz
Re #5: Removed dependency on protobuf code. It is left only for test …
63ad557 
…scope.
tkowalcz added a commit that referenced this issue Feb 7, 2021
@tkowalcz
Re #5: Some cleanups. Also added experimental test that records alloc…
93d1892 
…ations - results are mind blowing. Some improvements based on that test.
tkowalcz added a commit that referenced this issue Feb 7, 2021
@tkowalcz
Re #5: Snappy allocation optimisation - create and reuse largest poss…
f111286 
…ible hash table (array of shorts) with 16k entries.
tkowalcz added a commit that referenced this issue Feb 7, 2021
@tkowalcz
Re #5: Improved allocation test.
5a83a75
@tkowalcz tkowalcz linked a pull request Feb 7, 2021 that will close this issue
5 in house protobuf #30
Merged
@tkowalcz tkowalcz closed this as completed Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Relates to Core component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5 in house protobuf tkowalcz/tjahzi
1 participant
@tkowalcz