Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default linters included with EnableDefaultLinters set to false #9

Open
mhoofman opened this issue Apr 25, 2022 · 2 comments
Open

Default linters included with EnableDefaultLinters set to false #9

mhoofman opened this issue Apr 25, 2022 · 2 comments

Comments

@mhoofman
Copy link

mhoofman commented Apr 25, 2022

Thanks for the gem - works great along with the gitlab formatters!

A project I'm running has an erblint configuration set to not use any of the default linters using the configuration setting in .erb-lint.yml: EnableDefaultLinters: false without any other explicit configuration for default erblint linters.

Erb lint config example:

---
exclude:
  - '**/vendor/**/*'
  - '**/node_modules/**'
glob: "**/*.{html,text,js}{+*,}.erb"
EnableDefaultLinters: false
linters:
  Rubocop:
    enabled: true
    rubocop_config:
      inherit_from:
        - .rubocop.yml

However, pronto with erblint appears to include these default linters. For example running with pronto will include default linters:

bundle exec pronto run --runner=erb_lint

Running with erblint honors the erb-lint.yml configuration and does not run the default linters:

bundler exec erblint

How can pronto honor the .erb-lint.yml to not use the default linters from the EnableDefaultLinters setting?

Update

  • Changed erb-lint.yml to .erb-lint.yml.
@tleish
Copy link
Owner

tleish commented Dec 14, 2022

Are you using erb-lint.yml or .erb-lint.yml?

@mhoofman
Copy link
Author

I'm using .erb-lint.yml. I missed the leading dot in my original post - oops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants