You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I originally reported an issue in Jasmine: jasmine/jasmine#896 but now I think it would be actually more appropiate here.
I spent half an hour debugging this.
describe('stuff', function (done) {
it('works good', function () {
myHttp.get(url).then(function (response) {
expect(response.data.length).toBeGreaterThan(10000);
}).then(done, fail);
});
});
I got an error in some other unrelated test, with no stacktrace (because async), and had to fire up a debugger to understand what's happening. And it was just a simple mistake.
(In case you still didn't notice: I put done in describe instead of it.)
I believe this wouldn't be hard to do (as you already look at the arguments of the function given in it) and would save other programmers from mistakes like this.
The text was updated successfully, but these errors were encountered:
Do you know if there's any case when passing a argument to describe is valid? (I've not seen one myself). Otherwise, we could simply test on if (arguments.length) { return 'fail' }.
I originally reported an issue in Jasmine: jasmine/jasmine#896 but now I think it would be actually more appropiate here.
The text was updated successfully, but these errors were encountered: