Skip to content

Commit

Permalink
Continue showing active FCPs in individual nags
Browse files Browse the repository at this point in the history
I'd really like to see RFCs in active final comment period that I haven't reviewed yet. Especially since now is my last chance to review them!

The current filter was originally added to address rust-lang#212; I think this filter would have addressed that concern as well.
  • Loading branch information
tmandry authored Jan 11, 2024
1 parent 365810a commit 7e63df1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/nag.rs
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ pub fn individual_nags(username: &str) -> DashResult<(GitHubUser, Vec<Individual

let review_requests = fcp_review_request::table
.inner_join(fcp_proposal::table)
.filter(fcp_proposal::fcp_start.is_null())
.filter(fcp_proposal::fcp_closed.eq(false))
.filter(fcp_review_request::fk_reviewer.eq(user.id))
.filter(fcp_review_request::reviewed.eq(false))
.load::<(FcpReviewRequest, FcpProposal)>(conn)?;
Expand Down

0 comments on commit 7e63df1

Please sign in to comment.