Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser/get-screenshot-as requires casting #17

Open
jeroenvandijk opened this issue Jul 28, 2017 · 1 comment
Open

browser/get-screenshot-as requires casting #17

jeroenvandijk opened this issue Jul 28, 2017 · 1 comment

Comments

@jeroenvandijk
Copy link

Thank you for this library!

I was trying to get screenshots working. It took me a while before I figured out I had to do it outside of Webica because of casting:

It would be great if I could do this:

(chrome/start-chrome)
(browser/get "http://google.com")
(browser/get-screenshot-as org.openqa.selenium.OutputType/FILE)

However I need to do this to get it working:

(chrome/start-chrome)
(browser/get "http://google.com")
(.getScreenshotAs (cast org.openqa.selenium.TakesScreenshot (browser/instance)) org.openqa.selenium.OutputType/FILE)

Is this something Webica could do better or is it really an edge case?

@tmarble
Copy link
Owner

tmarble commented Jul 28, 2017

Oh that's a cool idea and absolutely something webica should do! Webica is all about being clever about casting things (so your application code doesn't have to be)! I'm working on a new version and I'll take a look at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants