Compatibility with vagrant-aws v0.4.0 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vagrant-aws v0.4.0 will remove the custom TimedProvision class and use only the standard Builtin::Provision instead. To support both old and new versions of the plugin, we check if the TimedProvision class is defined before using it. While at it, do the same check for vagrant-omnibus plugin, just in case it also changes in the future.
tmatilai
added a commit
that referenced
this pull request
Sep 27, 2013
Compatibility with vagrant-aws v0.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next vagrant-aws release will remove its custom
TimedProvisionclass and use only the standardBuiltin::Provisioninstead: mitchellh/vagrant-aws@dd17f23.To support both old and new versions of the plugin, we check if the
TimedProvisionclass is defined before using it.While at it, do the same check for vagrant-omnibus plugin, just in case it also changes in the future.