-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support git and svn configuration #49
Conversation
This adds support for overriding the HTTP proxy for Git by setting the system configuration. It uses the git command itself to write to the config file.
I ran into this while attempting to build MRI 1.8.7 which seems to checkout from the old Subversion repository. At any rate unfortunately ti seems that Subversion itself doesn't have a `config` command so we're left with simply writing it directly to /etc/subversion/servers.
Only do the magic if `config.git_proxy` or `config.svn_proxy` are specified.
Fixes crashing on `nil` or `false`.
The configuration also allows empty values.
Kick me later today/tonight if I haven't tested :). |
/me pokes @johnbellone ;) |
Ah thanks! We've got hit with some snow. I'm building a few machines now I'll grab this :). |
I'm merging this now, as I have planned some refactoring and want to avoid extra work for resolving conflicts. We can anyway fix the possible issues with this later. |
Support git and svn configuration
@tmatilai Sorry been in transit/conference for a few days. This looks good to me! If there are any issues I'll send PRs in. |
Hi I can't find a way to make SVN work with proxyconf. What am I missing ?
In another provisionning file ('cause git/svn seems to be configured by the plugin after each provisionner), a svn co obvisouly fails :( For Git, I had also to force it :
Thanks |
Hi @Bixibu , I have tried to understand by myself. I did not know how to configure Subversion and Git on vagrant-proxyconf. There is no description for svn and git on README.md. But we can set like this.
If you cannot solve by this, we need more detail of the phenomenon.
Thanks, |
Thanks both config.svn_proxy.http and VAGRANT_SVN_HTTP_PROXY works |
Builds on top of @johnbellone's #40.
Docs are missing, and the action classes (as all other action classes) would benefit from better testing. But in my manual testing this seems to work.
@johnbellone, could you also give it a spin?