Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support git and svn configuration #49

Merged
merged 12 commits into from
Feb 16, 2014
Merged

Support git and svn configuration #49

merged 12 commits into from
Feb 16, 2014

Conversation

tmatilai
Copy link
Owner

Builds on top of @johnbellone's #40.

Docs are missing, and the action classes (as all other action classes) would benefit from better testing. But in my manual testing this seems to work.
@johnbellone, could you also give it a spin?

John Bellone and others added 12 commits February 10, 2014 23:04
This adds support for overriding the HTTP proxy for Git by setting the
system configuration. It uses the git command itself to write to the
config file.
I ran into this while attempting to build MRI 1.8.7 which seems to
checkout from the old Subversion repository. At any rate unfortunately
ti seems that Subversion itself doesn't have a `config` command so we're
left with simply writing it directly to /etc/subversion/servers.
Only do the magic if `config.git_proxy` or `config.svn_proxy` are
specified.
Fixes crashing on `nil` or `false`.
The configuration also allows empty values.
@johnbellone
Copy link
Contributor

Kick me later today/tonight if I haven't tested :).

@tmatilai
Copy link
Owner Author

/me pokes @johnbellone ;)

@johnbellone
Copy link
Contributor

Ah thanks! We've got hit with some snow. I'm building a few machines now I'll grab this :).

@tmatilai
Copy link
Owner Author

I'm merging this now, as I have planned some refactoring and want to avoid extra work for resolving conflicts. We can anyway fix the possible issues with this later.

tmatilai added a commit that referenced this pull request Feb 16, 2014
Support git and svn configuration
@tmatilai tmatilai merged commit 70a8f7c into master Feb 16, 2014
@tmatilai tmatilai deleted the git_and_svn branch February 16, 2014 16:44
@johnbellone
Copy link
Contributor

@tmatilai Sorry been in transit/conference for a few days. This looks good to me! If there are any issues I'll send PRs in.

@jscti
Copy link

jscti commented Nov 6, 2014

Hi

I can't find a way to make SVN work with proxyconf. What am I missing ?
In my bootstrap.sh provision file I make a :

agt-get install subversion

In another provisionning file ('cause git/svn seems to be configured by the plugin after each provisionner), a svn co obvisouly fails :(
When i installed nodejs/npm, NPM got configured automatically.

For Git, I had also to force it :

git config --global http.proxy $http_proxy

Thanks

@otahi
Copy link
Collaborator

otahi commented Nov 6, 2014

Hi @Bixibu ,

I have tried to understand by myself. I did not know how to configure Subversion and Git on vagrant-proxyconf.

There is no description for svn and git on README.md. But we can set like this.

  config.proxy.http = "http://10.0.2.2:3128/"
  config.svn_proxy.http = "http://10.0.2.2:3128/"
  config.git_proxy.http = "http://10.0.2.2:3128/"

If you cannot solve by this, we need more detail of the phenomenon.

  • which OS do you use?
  • how about your Vagrantfile?

Thanks,

@otahi
Copy link
Collaborator

otahi commented Nov 6, 2014

I added documentation for Git and Subversion on #86.
@Bixibu

@jscti
Copy link

jscti commented Nov 17, 2014

Thanks both config.svn_proxy.http and VAGRANT_SVN_HTTP_PROXY works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants