Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy configuration outside of a login shell #58

Closed
williambailey opened this issue Apr 1, 2014 · 6 comments
Closed

Proxy configuration outside of a login shell #58

williambailey opened this issue Apr 1, 2014 · 6 comments
Assignees

Comments

@williambailey
Copy link

I'm wondering if it would be a good idea to have the option to update /etc/environment so that any proxy environment variables persist when using a non login shell.

By default vagrant uses bash -l to run commands via ssh however as witnessed by recent vagrant-omnibus changes sometimes a different shell is used and that shell might not process profile.d configuration. By having items in /etc/environment it should ensure that any proxy environmental variables are always available and therefore respected by any shell.

@johnbellone
Copy link
Contributor

@tmatilai Am a little bias since I work with the good sir @williambailey. Since this stemmed from a FreeBSD issue brought up in this vagrant-omnibus change perhaps we should just make an addition of a FreeBSD host capability and write to /etc/environment since it doesn't ship with bash?

@tmatilai
Copy link
Owner

tmatilai commented Apr 3, 2014

Hi there!

Agreed. That should also fix issue with test-kitchen which currently won't read /etc/profile, but should read /etc/environment. I'm fine writing our configuration to both. Only thing is that we should try to not override other configuration in /etc/environment.

Adding support for other that Linux guests is really great. There just haven't been any requests for them before.

I would be happy to see PRs for this. Personally I'm really busy at work with a project for the next couple of weeks, so can't promise anything before May/June.

@reneoelke
Copy link

I tried to develop this feature but i'm not aruby developer. So it would be nice that some one else could implement this important feature. Lot's of proxy problems would be solved with /etc/environment proxy settings.

@tmatilai
Copy link
Owner

Unless someone else takes this before, I definitely will work for this the next time I find a couple of hours FOSS time and energy, hopefully on the coming weekend.

@tmatilai
Copy link
Owner

tmatilai commented May 4, 2014

PR #67 tries to implement this. Feel free to test. =)

@reneoelke
Copy link

Thanks. Really good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants