Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vary header not set when response is negotiated #32

Open
dkubb opened this issue Jul 6, 2015 · 2 comments
Open

Vary header not set when response is negotiated #32

dkubb opened this issue Jul 6, 2015 · 2 comments

Comments

@dkubb
Copy link

dkubb commented Jul 6, 2015

When the response is negotiated based on the Accept headers the Vary header is not set.

There is a comment in g07 about setting Vary but I don't think you'd set Vary for that specific use case. As a general rule you want to append any request header that is examined and results in a logic branch that affects the response.

@reiddraper
Copy link
Collaborator

Thanks @dkubb! We're picking back work on Airship internally, so should get to these great issues you are filing soon. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants