Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings (like whether tiles are enabled, and screen resolution/fullscreen) should be saved #384

Open
nstoddard opened this issue Aug 31, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@nstoddard
Copy link
Contributor

It would be nice if settings, like whether tiles are enabled, screen resolution, and whether fullscreen is enabled, were saved, so it wasn't necessary to set them each time you open Brogue.

@nstoddard
Copy link
Contributor Author

It turns out there's command line options to set these: -G to enable tiles and -F to enable fullscreen. These solve my use case for this feature, though adding it might still be useful since most people won't want to write a script to launch Brogue with these flags.

@tmewett tmewett added the enhancement New feature or request label Apr 30, 2022
@nstoddard
Copy link
Contributor Author

Here's a (likely incomplete) list of settings that we probably want:

I think most of these settings should be modifiable at runtime; most of them already exist in-game, they're just not saved to disk. The file format should be simple enough to be easily parseable and writable, maybe something like this:

graphics: tiles
fullscreen: false
window_width: 1920
window_height: 1080
variant: vanilla
...

@zenzombie
Copy link
Collaborator

I think JSON is a good candidate format. Here's a library that might work: https://github.com/DaveGamble/cJSON

@esbudylin
Copy link

Hi! I decided to take a look on this issue. I'm working in this repo. I already implemented input and output functionality for a JSON config. I was able to add following settings:

  • graphical mode
  • game variant
  • replay speed
  • color effects
  • stealth range
  • wizard mode
  • easy mode

I also tried to take a look into window size settings, but I'm unsure about which part of the code is responsible for the window size. Perhaps you could point me in the right direction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants