Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Provider 3.35.0 Breaks this module #24

Closed
razorsedge opened this issue Apr 5, 2021 · 3 comments
Closed

AWS Provider 3.35.0 Breaks this module #24

razorsedge opened this issue Apr 5, 2021 · 3 comments

Comments

@razorsedge
Copy link

module "ssm-ps-creds" {
  source      = "git::https://github.com/tmknom/terraform-aws-ssm-parameter.git?ref=tags/2.0.0"

  name        = "/${var.environment}/${terraform.workspace}/admin"
  value       = "{\"username\": \"fake\", \"password\": \"fake\"}"
  description = "credentials"
  key_id      = var.kms_key_arn
  overwrite   = false
}
$ terraform plan

Error: expected length of allowed_pattern to be in the range (1 - 1024), got

  on .terraform/modules/ssm-ps-creds/main.tf line 46, in resource "aws_ssm_parameter" "default":
  46:   allowed_pattern = var.allowed_pattern

$ terraform version
Terraform v0.13.6
+ provider registry.terraform.io/hashicorp/aws v3.35.0

This works fine with AWS provider 3.34.0.

@razorsedge
Copy link
Author

hashicorp/terraform-provider-aws#17830 appears to be the culprit.

@denisbr
Copy link

denisbr commented Apr 6, 2021

Introducing validation is good, adding the wrong rule is not so good 🤦
Broke a bunch of our pipelines due to demanding > 0 length of description.

@razorsedge
Copy link
Author

This is fixed in AWS provider 3.36.0 (#18588).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants