Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework always missing using custom-engine #225

Closed
dalu93 opened this issue Apr 27, 2020 · 1 comment
Closed

Framework always missing using custom-engine #225

dalu93 opened this issue Apr 27, 2020 · 1 comment

Comments

@dalu93
Copy link

dalu93 commented Apr 27, 2020

Enhancement Suggestion / Bug Report

When running rome list --missing --platform iOS I see the framework which was just uploaded using custom-engine.

Steps which explain the enhancement or reproduce the bug

As a continuation of my post #218 (comment) I tried to run rome list --missing --platform iOS and the result is unexpected

Current behavior

$ rome list --missing --platform iOS
nantes 0.0.9 : -iOS

Suggested behavior

I would expect that this returns an empty list of missing frameworks

Why would the enhancement be useful to most users

We run carthage depending on the output of the previous command. With the current output, we end up re-building every time all the dependencies

Rome version:

0.23.2.63 - Romam uno die non fuisse conditam.

OS and version:

macOS 10.14.6 (18G4032)

EDIT

It seems that, when uploading/downloading frameworks, Rome appends Apple-Swift-version-5.1.3 to the file path, while it's not appending it when listing missing frameworks. Adding it manually works (using --cache-prefix)

@dalu93
Copy link
Author

dalu93 commented Apr 27, 2020

I'm sorry, I just figured out that the cache prefix is entirely created from our side and it's seem flaky. My bad.

@dalu93 dalu93 closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant