Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rome won't upload all downstream re-built frameworks #234

Open
stevedaontuc opened this issue Oct 12, 2020 · 3 comments
Open

Rome won't upload all downstream re-built frameworks #234

stevedaontuc opened this issue Oct 12, 2020 · 3 comments

Comments

@stevedaontuc
Copy link

Enhancement Suggestion / Bug Report

Add an option to detect all re-build downstream frameworks & upload them a long with missing frameworks.

Steps which explain the enhancement or reproduce the bug

For now, when we're building missing frameworks by this script:

$ rome list --missing --platform ios | awk '{print $1}' | xargs -I {} carthage build "{}" --platform ios

Carthage will re-build all downstream dependencies, Rome should upload all of them instead of missing frameworks.

Current behavior

Rome only upload missing frameworks.

Suggested behavior

Rome should upload all re-built downstream frameworks a long with missing frameworks.

Why would the enhancement be useful to most users

Some re-built downstream frameworks are only valid with missing frameworks at the moment. 

Rome version:

v0.23.3.64

OS and version:

MacOS Catalina 10.15.7
@stevedaontuc stevedaontuc changed the title Rome won't upload all built frameworks Rome won't upload all downstream re-built frameworks Oct 12, 2020
@tmspzz
Copy link
Owner

tmspzz commented Oct 12, 2020

You can just run upload at the end and it will upload all frameworks.

Rome does not keep state and it shouldn't. It only deals with the cache. It's up to the user to know the set of frameworks to upload/download.

@stevedaontuc
Copy link
Author

Yes, we can do that but it isn't a nice way to do. I understand this optimization is not easy since Carthage won't export how many downstream dependencies would be re-built. Hope to see some expertises of Carthage here or I may need to post to Carthage page. Thank for your reply @tmspzz

@tmspzz
Copy link
Owner

tmspzz commented Oct 12, 2020

You can parse Carthage's output after the line

rebuilding all downstream dependencies

And pipe the names of the frameworks that have been rebuilt to Rome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants