Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[offline][android] fixed issues caused by new android API #544

Conversation

felix-ht
Copy link
Collaborator

The new api no longer passes the registrar. onMethodCall was still expecting it, and thus causes the api to be dysfunctional for flutter apps using the new api version

closes #543

@felix-ht felix-ht changed the title fixed issues caused by new android API [offline][android] fixed issues caused by new android API Feb 16, 2021
@shroff shroff self-requested a review February 16, 2021 15:26
Copy link
Collaborator

@shroff shroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @felix-ht ! I made these changes according to the old api and didn't update

@shroff shroff merged commit 8be3575 into flutter-mapbox-gl:master Feb 16, 2021
@felix-ht
Copy link
Collaborator Author

@shroff would it make sense to release this as a 0.10.1?

@shroff
Copy link
Collaborator

shroff commented Feb 16, 2021

Makes sense to me, but that's a question for @tobrun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android/Example: offline region manager broken
2 participants