Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requestMyLocationLatLng in the platform interface #697

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

shroff
Copy link
Collaborator

@shroff shroff commented Sep 26, 2021

It was crashing for me with the following error:

flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: type '_InternalLinkedHashMap<Object?, Object?>' is not a subtype of type 'Map<Object, Object>'

No reason to use <Object, Object> types instead of <dynamic, dynamic> as
used everywhere else

It was crashing for me with the following error:
```
flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: type '_InternalLinkedHashMap<Object?, Object?>' is not a subtype of type 'Map<Object, Object>'
```

No reason to use <Object, Object> types instead of <dynamic, dynamic> as
used everywhere else
@shroff shroff had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN September 26, 2021 06:21 Failure
@shroff shroff had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN September 26, 2021 06:21 Failure
@shroff
Copy link
Collaborator Author

shroff commented Sep 26, 2021

This is already done in #658, but with a suboptimal approach. I'll wait for that to be committed correctly before closing

Copy link
Collaborator

@felix-ht felix-ht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felix-ht felix-ht merged commit 82e3947 into master Oct 15, 2021
@shroff shroff deleted the fix-requestMyLocationLatLng branch October 24, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants