Enable onMapIdle callback for android
#729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the android piece of PR #214. The listener `MapView.OnDidBecomeIdleListener` is less well documented than its iOS counterpart. We just have this to go on: > Interface definition for a callback to be invoked when the map has > entered the idle state. https://docs.mapbox.com/android/maps/api/9.6.1/com/mapbox/mapboxsdk/maps/MapView.OnDidBecomeIdleListener.html Fr the iOS framework method we have more detailed information: > Tells the delegate that the map view is entering an idle state, and no > more drawing will be necessary until new data is loaded or there is > some interaction with the map. > * No camera transitions are in progress > * All currently requested tiles have loaded > * All fade/transition animations have completed https://docs.mapbox.com/archive/ios/maps/api/5.6.1/Protocols/MGLMapViewDelegate.html#/c:objc(pl)MGLMapViewDelegate(im)mapViewDidBecomeIdle: After testing with these changes, it does seem to be the case that it is only invoked after the tiles are loaded. So I think this is the correct analogue for the iOS listener.
m0nac0
approved these changes
Oct 31, 2021
|
LGTM me as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the android piece of PR #214.
The listener
MapView.OnDidBecomeIdleListeneris less welldocumented than its iOS counterpart. We just have this to go on:
https://docs.mapbox.com/android/maps/api/9.6.1/com/mapbox/mapboxsdk/maps/MapView.OnDidBecomeIdleListener.html
For the iOS framework method we have more detailed information:
https://docs.mapbox.com/archive/ios/maps/api/5.6.1/Protocols/MGLMapViewDelegate.html#/c:objc(pl)MGLMapViewDelegate(im)mapViewDidBecomeIdle:
After testing with these changes, it does seem to be the case that it is
only invoked after the tiles are loaded. So I think this is the correct
analogue for the iOS listener.