Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: asyncpg Queue backend #172

Closed
cofin opened this issue Oct 6, 2024 · 6 comments
Closed

Feature: asyncpg Queue backend #172

cofin opened this issue Oct 6, 2024 · 6 comments

Comments

@cofin
Copy link

cofin commented Oct 6, 2024

It's nice to see a Postgres backend added. I'm just starting to experiment with it, and so far, it's great.

I'm curious do you have plans to offer an an asyncpg based Queue in addition the current psycopg implementation? If not, would you be willing to accept a PR adding support?

@tobymao
Copy link
Owner

tobymao commented Oct 6, 2024

hey @cofin, probably not unless the PR is extremely minimal. i don't think there would be much benefit to it. going to close this issue for now but happy to discuss

@tobymao tobymao closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2024
@cofin
Copy link
Author

cofin commented Oct 8, 2024

@tobymao maybe I could ask for your opinion then.

The LGPL license that psycopg has is problematic for my use case (and many other organization have a similar stance). What was the reason for using psycopg over asyncpg? Are there additional features (other than sync support) that psycopg offers?

Just to further clarify my use case. All of the databases I would connect to are Google CloudSQL or AlloyDB instances. There's a convenient asyncpg integration for the auth proxy, but there is no such library for psycopg.

@tobymao tobymao reopened this Oct 8, 2024
@tobymao
Copy link
Owner

tobymao commented Oct 8, 2024

@cofin i change my mind. due to it being lgpl, i'll accept a PR that replaces psycopg with it. will you make a PR? i'm currently quite constrained so may not be able to do it

@tobymao tobymao closed this as completed Oct 8, 2024
@tobymao tobymao reopened this Oct 8, 2024
@tobymao tobymao closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
@cofin
Copy link
Author

cofin commented Oct 8, 2024

@tobymao, Thanks for reconsidering. I don't mind creating the PR, and I've actually made a bit of progress on it already. Did you want me to remove the psycopg implementation or allow for either to be used?

@tobymao
Copy link
Owner

tobymao commented Oct 8, 2024

probably remove it. is it a pretty easy switch?

@cofin
Copy link
Author

cofin commented Oct 8, 2024

probably remove it. is it a pretty easy switch?

Yes, for the most part.

The main changes are around prepared statements and the way the listen/notify mechanism works. I'll submit the PR with them both added, you can weigh in once more. At that point, I can remove the psyocpg adapter before we merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants